Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for .h files, and support for UIBarButtonItem customView #13

Merged
merged 3 commits into from Mar 27, 2013

Conversation

DinosaurDad
Copy link

No description provided.

@wbyoung
Copy link
Contributor

wbyoung commented Mar 27, 2013

Thanks for the contribution, it looks good! Is there a reason that you've added logging to the strings file creation? Was it for debugging or did you just want the more verbose output?

@DinosaurDad
Copy link
Author

I was just trying to verify that my .h files were in fact being processed. I didn't mean to leave it in there. I can recommit without it if you'd like.

Thanks for the library, by the way. I was using a self-built solution that did something similar, but was nowhere near as elegant or complete.

@wbyoung
Copy link
Contributor

wbyoung commented Mar 27, 2013

Yea, let's take it out. Otherwise, everything else looks good!

@DinosaurDad
Copy link
Author

Ok, I committed removal of the logging. Do you need a new pull request?

wbyoung added a commit that referenced this pull request Mar 27, 2013
Support for .h files, and support for UIBarButtonItem customView
@wbyoung wbyoung merged commit d163573 into fadingred:master Mar 27, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants